Fix log files not working in daemon mode, update some dependencies and silence poll interrupted error #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ality of life additions to the cli to enable log files working in daemon mode and setting pid files and env directories
kennytm
reviewed
May 26, 2024
| .open(log) | ||
| .unwrap_or_else(move |_| panic!("Could not create log file {}", &log)); | ||
|
|
||
| let (non_blocking, _guard) = tracing_appender::non_blocking(log_file); |
There was a problem hiding this comment.
The _guard and thus log file will be dropped at the end of this branch. The _guard must be held at the top level in order for the log to keep working, i.e.
fn main() {
...
let _guard;
...
let (non_blocking, guard) = tracing_appender::non_blocking(log_file);
_guard = guard;
...this is basically the approach in the main branch
boringtun/boringtun-cli/src/main.rs
Lines 103 to 113 in f672bb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to the cli to set pid files, useful for systemd units. I added the ability to set a working dir, and updated daemonize and tracing to the latest versions. Logging to files now work in daemon mode, as well as no complaints from epoll about being interrupted